Skip to content

Conversation

@Legends0
Copy link
Collaborator

Actually was able to test a similar situation in m12s and found that the issue could happen, albeit less likely in m8s since these possible values are very close to or off the platform.

fixes #752

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Jan 27, 2026
@Legends0 Legends0 changed the title raidboss: m8s replace Math.abs in Hero's Blow Left cleaves raidboss: r8s replace Math.abs in Hero's Blow Left cleaves Jan 27, 2026
@github-actions github-actions bot removed the needs-review Awaiting review label Jan 28, 2026
@Legends0 Legends0 merged commit e3db552 into main Jan 28, 2026
17 checks passed
@Legends0 Legends0 deleted the Legends0-patch-1 branch January 28, 2026 20:36
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
…eaves (#976)

Actually was able to test a similar situation in m12s and found that the
issue could happen, albeit less likely in m8s since these possible
values are very close to or off the platform.

fixes #752 e3db552
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
…eaves (#976)

Actually was able to test a similar situation in m12s and found that the
issue could happen, albeit less likely in m8s since these possible
values are very close to or off the platform.

fixes #752 e3db552
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 28, 2026
…eaves (OverlayPlugin#976)

Actually was able to test a similar situation in m12s and found that the
issue could happen, albeit less likely in m8s since these possible
values are very close to or off the platform.

fixes OverlayPlugin#752 e3db552
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 28, 2026
…eaves (OverlayPlugin#976)

Actually was able to test a similar situation in m12s and found that the
issue could happen, albeit less likely in m8s since these possible
values are very close to or off the platform.

fixes OverlayPlugin#752 e3db552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is Math.abs() used in M8S Hero's Blow

3 participants